[Webkit-unassigned] [Bug 40353] [Qt] Remove superfluous function calls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 14 11:03:48 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40353





--- Comment #9 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-14 11:03:47 PST ---
(In reply to comment #8)
> @Kenneth:
> 
> You mean an inline comment?
> 
> E.g.
> 
> void QWebFrame::load(const QUrl &url) 
> { 
>     // No need to call ensureAbsoluteUrl() here since ::load(QNetworkRequest) 
>     // will do it.
>     load(QNetworkRequest(url)); 
> } 
> 
> It seems a little un-qt-like to me I have to admit.

Well, not very un-WebKitish anyway. And apparently someone added the ensureAb... before.

Something like:

// The load() overload ensures that the url is absolute.
load(QNetworkRequest(url));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list