[Webkit-unassigned] [Bug 40564] New: Animation: Bad removal from style available wait list

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40564

           Summary: Animation: Bad removal from style available wait list
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: joel at rosdahl.net


The algorithm in AnimationControllerPrivate::removeFromStyleAvailableWaitList has a bug: prevAnimation is always 0, which means that if animationToRemove is not the first element in m_styleAvailableWaiters, the elements before animationToRemove are lost.

See also the very similar algorithm in AnimationControllerPrivate::removeFromStartTimeResponseWaitList (maybe the code should be refactored?).

Unfortunately, I'm not able to supply a web page that reproduces the bug, but I hope it's obvious enough even without one.

The bug was seen on WebKit Safari-6531.22.2, but exists on current trunk (r61111) as well.

Fix:

Index: WebCore/page/animation/AnimationController.cpp
===================================================================
--- WebCore/page/animation/AnimationController.cpp    (revision 61111)
+++ WebCore/page/animation/AnimationController.cpp    (working copy)
@@ -366,6 +366,7 @@ void AnimationControllerPrivate::removeFromStyleAv

             animationToRemove->setNext(0);
         }
+        prevAnimation = animation;
     }
 }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.