[Webkit-unassigned] [Bug 5861] feConvolveMatrix filter is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5861


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #7 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-06-14 04:45:57 PST ---
Attachment 58634 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/svg/SVGFEConvolveMatrixElement.cpp:112:  _kernelMatrix is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/svg/SVGFEConvolveMatrixElement.cpp:120:  _orderX is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/svg/SVGFEConvolveMatrixElement.cpp:121:  _orderY is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/svg/SVGFEConvolveMatrixElement.cpp:129:  _targetX is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/svg/SVGFEConvolveMatrixElement.cpp:130:  _targetY is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/svg/SVGFEConvolveMatrixElement.cpp:140:  _divisor is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/svg/SVGFEConvolveMatrixElement.cpp:141:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/svg/SVGFEConvolveMatrixElement.cpp:146:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebCore/svg/SVGFEConvolveMatrixElement.cpp:153:  Should have a space between // and comment  [whitespace/comments] [4]
WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp:34:  Use 'using namespace std;' instead of 'using std::min;'.  [build/using_std] [4]
WebCore/svg/graphics/filters/SVGFEConvolveMatrix.cpp:35:  Use 'using namespace std;' instead of 'using std::max;'.  [build/using_std] [4]
Total errors found: 11 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.