[Webkit-unassigned] [Bug 35350] DumpRenderTree should allow tests with modal dialogs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35350


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57603|review?                     |review-
               Flag|                            |




--- Comment #5 from Darin Adler <darin at apple.com>  2010-06-13 21:25:42 PST ---
(From update of attachment 57603)
> -    [m_webView performSelector:@selector(_closeWindow) withObject:nil afterDelay:0.0];
> +    [m_webView performSelector:@selector(_closeWindow) withObject:nil afterDelay:0.0
> +        inModes:[NSArray arrayWithObjects:NSDefaultRunLoopMode, NSModalPanelRunLoopMode,
> +                 NSConnectionReplyMode, NSEventTrackingRunLoopMode, nil]];

This change is not needed to make showModalDialog work in DumpRenderTree. Making this change could affect the behavior of applications on Mac and so the decision of whether to change it should not be driven by the needs of our test tool alone.

The rest of the patch seems OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.