[Webkit-unassigned] [Bug 39482] RGB colors should be clamped to the 0-255 range

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39482


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hyatt at apple.com




--- Comment #9 from Eric Seidel <eric at webkit.org>  2010-06-12 20:56:44 PST ---
I would suspect that color parsing would be hot code.  The PLT would be one way to test, but running it is basically impossible unless you work at Apple (or Google if you're running it in Chrome).

You could write a little js page which parsed various colors in a loop using the CSS DOM or by calling  style.backgroundColor =  or setAttribute("color", ...).  You'd have to use shark or sample to verify that your benchmark actually hit the color code.  If so, then that would easily prove or disprove that this did or did not change performance of color parsing. :)  Whether changing color parsing performance would change the PLT is another quesiton, but if you didn't change color parsing perf then you obviously didn't change the PLT. :)

We used a similar approach for testing the HTML5 parser.  See WebCore/benchmarks/parsing/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.