[Webkit-unassigned] [Bug 13097] Unsupported content:inherit value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=13097


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53180|review?                     |review-
               Flag|                            |




--- Comment #11 from Darin Adler <darin at apple.com>  2010-06-12 19:10:22 PST ---
(From update of attachment 53180)
Looks good.

> +        if (id == CSSValueNormal ||
> +            id == CSSValueNone)
> +            validPrimitive = true;
> +        else {
> +            return parseContent(propId, important);
> +        }

No braces around a single-line else. No need to break that up into multiple lines. I suggest this formatting:

    if (id == CSSValueNormal || id == CSSValueNone)
        validPrimitive = true;
    else
        return parseContent(propId, important)
    break;

review- because this patch includes a new regression test but does not include the expected result for the test

It would also be best if the test could be changed so that it can be dumpAsText instead, as we have done for many style tests in the past. But what's mandatory is including the expected results.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.