[Webkit-unassigned] [Bug 37939] Fix PluginViewNone.cpp compilation for ports that also compile PluginView.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37939


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53990|review?                     |review+
               Flag|                            |




--- Comment #6 from Darin Adler <darin at apple.com>  2010-06-12 18:59:53 PST ---
(From update of attachment 53990)
> +// FIXME: PluginViewNone.cpp should be a drop-in stubs file for a port's 
> +// PluginView<Port>.cpp file and should only contain port-specific methods. 
> +// These three APIs in the PLATFORM(MAC) block are not port-specific and 
> +// are only here because the Mac port wishes not to compile PluginView.cpp, 
> +// where the implementations for these methods live. Note also that it does not
> +// need any of the other method stubs in this file. These functions probably
> +// belong in a Mac-specific file somewhere.

This comment is too big and I found it confusing. You should find a way of saying this with fewer words or just leave the comment out.

That part about "Mac port wishes not to compile" is inaccurate. WebKit contributors want the Mac port to share more code with the plug-in handling on the other ports. The Mac plug-in handling predates the plug-in handling done for other ports and the programmers who worked on plug-in machinery later on built on work done for the Windows port and never did the work to make the new code paths be used on Mac. If we really need a comment like this, a better one would make it clear that the future direction is to share more code and would not anthropomorphize the Mac port with a naughty uncooperative personality.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.