[Webkit-unassigned] [Bug 40005] [Qt] Platform plugin support for Notifications UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40005





--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-12 07:56:15 PST ---
(From update of attachment 58550)
WebKit/qt/examples/platformplugin/WebNotificationPresenter.h:50
 +      WebNotificationPresenter(const QString& title, const QString& message, const QByteArray& bytes) : QWebNotificationPresenter(title, message, bytes)
Put the : part on the next line.

WebKit/qt/examples/platformplugin/WebPlugin.h:92
 +      virtual QWebNotificationPresenter* createNotificationPresenter(const QString& title, const QString& message, const QByteArray& bytes) const { if (supportsExtension(Notifications)) return new WebNotificationPresenter(title, message, bytes); return 0; }
I would put the contents part on some other lines. This is barely readable.

WebKit/qt/examples/platformplugin/qwebkitplatformplugin.h:86
 +      virtual QWebNotificationPresenter* createNotificationPresenter(const QString& title, const QString& message, const QByteArray&) const = 0;
Wouldn't it be better to make this similar to the SelectMethod? so that you can access the info (title, message, etc) from inside the function via an accessor. We never know what is going to be added here in the future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.