[Webkit-unassigned] [Bug 40328] GtkLauncher fails to build: Undefined references to openFile, readFromFile, and seekFile

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40328





--- Comment #6 from Dirk Schulze <krit at webkit.org>  2010-06-11 23:19:21 PST ---
(From update of attachment 58536)
This is not an official review, but i would like to give some hints.WebCore/ChangeLog:5
 +          Add to FileSystemGtk.cpp methods openFile, readFromFile
The order in Changelogs is normally bug title, bug link, description to the patch and added tests. The patch WebKitTools/Scripts/prepare-ChangeLog -bug <bug-number> will help you to create the changelog.

WebCore/platform/gtk/FileSystemGtk.cpp:34
 +  #include <unistd.h>
You added this include twice now.

WebCore/platform/gtk/FileSystemGtk.cpp:267
 +  // Following the implementation for closeFile above, implement openFile
Please indent all comments with the code.

WebCore/platform/gtk/FileSystemGtk.cpp:286
 +  // as the pattern for implementing readFromFile
dito.

WebCore/platform/gtk/FileSystemGtk.cpp:292
 +  // Handle EOF on read
dito.

WebCore/platform/gtk/FileSystemGtk.cpp:305
 +  // just use code from WebCore/platform/posix/FileSystemPOSIX.cpp
dito.

You either added a new feature, or fixed a regression. Both need layouttesting...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.