[Webkit-unassigned] [Bug 40005] [Qt] Platform plugin support for Notifications UI

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 16:43:31 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40005





--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-11 16:43:29 PST ---
(In reply to comment #6)
> WebKit/qt/Api/qwebkitplatformplugin.h:61
>  +  class QWebNotificationUi : public QObject
> I dont like the Ui part of the name. Isn't this more or less like a notification controller? or notification dispatcher?
> 
> WebKit/qt/Api/qwebkitplatformplugin.h:68
>  +      virtual void showNotification() = 0;
> If this class is a notification itself, this should probably just be called show() or appear()
> 
> WebKit/qt/Api/qwebkitplatformplugin.h:81
>  +          Notifications
> Maybe we should extend this with SingleSelections as well?
> 
> WebKit/qt/Api/qwebkitplatformplugin.h:72
>  +  };
> What string do I receive??

actually I like the WebCore name, so what about createNotificationPresenter?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list