[Webkit-unassigned] [Bug 40420] Web Inspector: Prevent from copying "filename.css" in Styles pane

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40420


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58382|review?                     |review-
               Flag|                            |




--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2010-06-11 06:03:15 PST ---
(From update of attachment 58382)
Couple of nits.

WebCore/inspector/front-end/Section.js:86
 +          if (x instanceof Node) {
I don't think we should extend section's api to accept both text and Nodes as subtitles. subtitle setter is a convenience method for setting text. Should client need greater extensibility, he is free to access subtitleElement explicitly.

WebCore/inspector/front-end/StylesSidebarPane.js:654
 +                  var link = WebInspector.linkifyResourceAsNode(url, "resources", this.rule.sourceLine + 1);
So I would leave this code as is with appending child here as it used to be.

WebCore/inspector/front-end/inspector.css:4041
 +  .styles-section .header [data-uncopyable]::before {
You should just apply this to ".styles-section .subtitle".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.