[Webkit-unassigned] [Bug 40301] DOM storage should only create databases when needed

Fri Jun 11 03:40:46 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40301

Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58233|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |

--- Comment #8 from Jeremy Orlow <jorlow at chromium.org>  2010-06-11 03:40:46 PST ---
(From update of attachment 58233)
WebCore/ChangeLog:8
 +          As soon as a page attempts to use localstorage, StorageAreaSync will create an empty database if one doesn't already exist. This can lead to lots of unnecessary database files. In particular, they are created even when the privacy settings or private browsing mode disallow localstorage data, which may seem odd to the user.
This is all on one line.  Please wrap.

WebCore/manual-tests/localstorage-empty-database.html:6
 +  </body>
Why end the body before the body?  :-)

WebCore/storage/StorageAreaSync.cpp:203
 +  void StorageAreaSync::openDatabase(OpenDatabaseParamType create)
Create is probably not the best name for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.