[Webkit-unassigned] [Bug 40418] Removes duplication between platform/chromium-win and platform/chromium-mac test expectations by moving files to platform/chromium.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 03:19:00 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40418





--- Comment #5 from Marcus Bulach <bulach at chromium.org>  2010-06-11 03:19:00 PST ---
(In reply to comment #3)
> (From update of attachment 58369 [details])
> > +        * platform/chromium-win/fast/dom/SelectorAPI/README: Removed.
> > +        * platform/chromium/fast/dom/SelectorAPI/README: Renamed from LayoutTests/platform/chromium-mac/fast/dom/SelectorAPI/README.
> Should README file be removed? Think it would be better to keep README in same folder with the expectation files in this case.

Good point, thanks Victor! I changed the script a bit so it now only deals with .txt files. Would you mind taking another look and double check it's fine, please?

fdupes -r chromium* | grep -A1 "chromium-win/.*txt" | grep -B1 chromium-mac \
| grep -v "regexp-overflow-expected\.txt" | grep -v '\-\-' > dupes.txt
python << EOF
import os
import shutil
f = []
for l in file('dupes.txt').readlines():
  f.append(l.replace('\n',''))
while len(f):
  if os.path.basename(f[0]) == os.path.basename(f[1]):
    print 'Moving ' + f[0]
    dest = f[0].replace('-win','')
    if not os.path.exists(os.path.dirname(dest)):
      os.makedirs(os.path.dirname(dest))
    shutil.move(f[0], dest)
    os.system('git add ' + dest)
    os.unlink(f[1])
  del f[:2]
EOF

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list