[Webkit-unassigned] [Bug 30116] WebCore::InsertLineBreakCommand::shouldUseBreakElement ReadAV at NULL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30116





--- Comment #24 from Tony Chang (Google) <tony at chromium.org>  2010-06-10 18:04:20 PST ---
(In reply to comment #23)
> (In reply to comment #21)
> > Is this code really only hit in plaintext regions? Doesn't non-plaintext contentEditable hit this codepath as well? If it really is just for plain text, then I think we don't need to worry about canonicalization.
> 
> Oh, I see, you're saying in other cases, we may need to canonicalize.  Hmm, maybe, but it's not obvious to me that it is necessary without a test case.

And if we are concerned about that, then we should just go with the original patch that null checks |caret|.  It won't insert a line, but that's bug 40342.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.