[Webkit-unassigned] [Bug 30116] WebCore::InsertLineBreakCommand::shouldUseBreakElement ReadAV at NULL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30116





--- Comment #22 from Tony Chang (Google) <tony at chromium.org>  2010-06-10 18:00:33 PST ---
(In reply to comment #21)
> > > Before this patch, pos pointed to the deepEquivalent (canonicalized node). After this patch, it just points to m_start, which may or may not be canonicalized. Right?
> > 
> > Sure, but what canonicalization needs to happen?  I.e., do you have an example test case that this breaks?  Since this is just plain text, I'm not sure we need to canonicalize here.
> 
> Is this code really only hit in plaintext regions? Doesn't non-plaintext contentEditable hit this codepath as well? If it really is just for plain text, then I think we don't need to worry about canonicalization.

Yes, the change to InsertLineBreakCommand is for plain text and the change to InsertParagraphSeparatorCommand is for rich text.  Specifically, the decision is made here:
http://trac.webkit.org/browser/trunk/WebCore/page/EventHandler.cpp#L2596
And TextEvent::isLineBreak() is set by the third parameter here:
http://trac.webkit.org/browser/trunk/WebCore/editing/EditorCommand.cpp#L515



> Not sure what you're asking for here. The code hasn't changed, so there's only comments to respond to.

I was unclear to me if the FIXMEs you mentioned in comment 18 were both about the same code or if you wanted 2 FIXMEs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.