[Webkit-unassigned] [Bug 23588] Add inputmode attribute support, as per XHTML Basic 1.1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23588





--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2010-06-10 11:31:48 PST ---
Some comments in passing:

+contains(DEFINES, ENABLE_XHTMLBASIC=1): FEATURE_DEFINES_JAVASCRIPT += ENABLE_XHTMLBASIC=1

The feature should be implemented in a way that it either works, or is undetectable from JavaScript - even if someone mistakenly enables the feature define, this invariant shouldn't be broken.

+// The code is here for reference purpose, each platform should implement the input mode switching based on 
+// the platform capability and the inputmode attribute, like digit, upperCase, lowerCase, or any language-specific
+// input methods
+
+#if 0

We don't normally land commented out code. And implementation for a specific platform is not a place where one would easily find such explanation.

+        Need a short description and bug URL (OOPS!)

It does!

> Index: LayoutTests/platform/qt/fast/xhtmlbasic/xhtmlbasic11-expected.txt

Is there a reason for the test to not be dumpAsText?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.