[Webkit-unassigned] [Bug 40397] [Chromium] Add the ability to specify a separator in AutoFillPopupMenuChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40397





--- Comment #4 from James Hawkins <jhawkins at chromium.org>  2010-06-10 10:53:36 PST ---
(In reply to comment #2)
> (From update of attachment 58316 [details])
> WebKit/chromium/public/WebViewClient.h:295
>  +      virtual void didAcceptAutoFillSuggestion(const WebNode&,
> perhaps you should keep the old form of this method around and make
> the default implementation of this method call that one?  that way
> you won't require a two-sided patch landing to avoid regressing chrome?
> 

I'll commit the chromium side first, which adds the new method and deprecates the old, obviating the need for the old method in the API.

> WebKit/chromium/src/AutoFillPopupMenuClient.cpp:63
>  +        return suggestion;
> nit: indent by 4 spaces
> 

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.