[Webkit-unassigned] [Bug 40278] [EFL] EFLWebKit doesn't support viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40278





--- Comment #10 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-06-10 06:09:26 PST ---
Hi Gyuyoung Kim, patch is highly improved! Thanks. Very minor nitpickings to make it perfect:

 * The comment of ewk_view_viewport_set() is now incorrect:
       Emits signal: "viewport,changed" with arguments of viewport
   You now have no arguments (NULL/0 is used).

 * As ewk_view_viewport_set() is internal/private just to WebCoreSupport usage, it should be in ewk_private.h, not ewk_view.h

 * Missing signal "viewport,changed" documentation in ewk_view.h

 * ewk_view_viewport_get() is not @internal, rather for public usage. Maybe copy & paste from the _set()? (The setter should be considered internal, as it is just to be provided from WebCoreSupport)

 * As other EFL, ewk_view_viewport_get() should get optional arguments. So you should check if any of the given return pointers are not NULL:
       - *w = priv->settings.viewport.w;
       + if (w) *w = priv->settings.viewport.w;


Now some important questions, as ViewportArguments.h is not in my knowledge domain but may result in bugs if not handled properly:

  1. Should the meta tag ALWAYS be enforced in the user? Should it always prohibit users from changing zoom level or limiting the available zoom range? I don't think so. It should be only enforced by Browsers and thus ewk_view users.   If this is the case, then you must have a different structure to hold WebCore/dom reported values, and another one that is user-settable with the values to enforce with ewk_view_zoom_range_set() and ewk_view_user_scalable_set(). With this approach you will also need ewk_view_zoom_range_get() and ewk_view_user_scalable_get() as ewk_view_viewport_get() will always report the original WebCore/dom values.   In any case, you must document this behavior and side-effects in the public API in ewk_view.cpp

  2. How to reset these values on new page load? Are you sure WebCore/dom will always report new value for each visited page, even if the page does not contain the mentioned meta tag? If does and allows you to reset the values, good, otherwise you'd have to reset these values yourself. Failing to do so will result in bugs when user visits one page that applies the tag and then goes to another that does not and is not prepared to handle those constraints.

As I'm not an official reviewer, I'll try to find someone that knows about it to comment on these questions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.