[Webkit-unassigned] [Bug 39357] [QT] QT_BEARER flag is not enabled on S60 properly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39357





--- Comment #23 from maheshK <mahesh.kulkarni at nokia.com>  2010-06-10 04:37:53 PST ---
(In reply to comment #22)
> (In reply to comment #19)
> > This created a warning when QtMobility is not available. Following change would fix it:
> > 
> > Index: WebCore/WebCore.pri
> > ===================================================================
> > --- WebCore/WebCore.pri (revision 60842)
> > +++ WebCore/WebCore.pri (working copy)
> > @@ -115,7 +115,7 @@
> >       !lessThan(QT_MINOR_VERSION, 7) {
> >          DEFINES += ENABLE_QT_BEARER=1
> >       } else {
> > -        load(mobilityconfig)
> > +        exists($$[QMAKE_MKSPECS]/features/mobility.prf): load(mobilityconfig)
> >          contains(MOBILITY_CONFIG, bearer) {
> >              DEFINES += ENABLE_QT_BEARER=1
> >          }
> 
> A better fix is to replace
> 
> load(mobilityconfig)
> 
> with
> 
> load(mobilityconfig,true)
> 
> where the second argument (true) means: ignore errors when loading

Nice! Thanks 
patch from 39724 covers the change for this case as well as we will be loading mobilityconfig only once.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.