[Webkit-unassigned] [Bug 40418] New: Removes duplication between platform/chromium-win and platform/chromium-mac test expectations by moving files to platform/chromium.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 10 04:20:56 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40418

           Summary: Removes duplication between platform/chromium-win and
                    platform/chromium-mac test expectations by moving
                    files to platform/chromium.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: bulach at chromium.org


Following discussions from:
https://bugs.webkit.org/show_bug.cgi?id=39721
http://code.google.com/p/chromium/issues/detail?id=46142

We need to remove duplication between test expectations on platform/chromium-win and platform/chromium-mac.

This is due the following fallback logic:
platform/chromium-linux => platform/chromium-win -> platform/chromium
and
platform/chromium-mac -> platform/chromium

I used the following one-off script to create this patch:


fdupes -r chromium* | grep -A1 "chromium-win/" | grep -B1 chromium-mac | grep -v '\-\-' > dupes.txt
python << EOF
import os
import shutil
f = []
for l in file('dupes.txt').readlines():
  f.append(l.replace('\n',''))
while len(f):
  if os.path.basename(f[0]) == os.path.basename(f[1]):
    print 'Moving ' + f[0]
    dest = f[0].replace('-win','')
    if not os.path.exists(os.path.dirname(dest)):
      os.makedirs(os.path.dirname(dest))
    shutil.move(f[0], dest)
    os.system('git add ' + dest)
    os.unlink(f[1])
  del f[:2]
EOF

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list