[Webkit-unassigned] [Bug 40397] [Chromium] Add the ability to specify a separator in AutoFillPopupMenuChromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40397


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58316|review?                     |review-
               Flag|                            |




--- Comment #2 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-06-09 22:25:35 PST ---
(From update of attachment 58316)
WebKit/chromium/public/WebViewClient.h:295
 +      virtual void didAcceptAutoFillSuggestion(const WebNode&,
perhaps you should keep the old form of this method around and make
the default implementation of this method call that one?  that way
you won't require a two-sided patch landing to avoid regressing chrome?

WebKit/chromium/src/AutoFillPopupMenuClient.cpp:63
 +        return suggestion;
nit: indent by 4 spaces

looks ok otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.