[Webkit-unassigned] [Bug 38826] Don't convert filenames to URLs in edit drags.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 9 13:41:32 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=38826
--- Comment #24 from Daniel Cheng <dcheng at chromium.org> 2010-06-09 13:41:29 PST ---
(In reply to comment #22)
> (From update of attachment 58205 [details])
> > > LayoutTests/ChangeLog:14
> > > + (moveMouseToCenterOfElement):
> > > No need to show these new methods in js.
> > >
> >
> > This is the output from prepare-ChangeLog. I felt best to leave it that way.
> Yes, this is output from prepare-ChangeLog. But many people choose not to add new methods from the new file.
>
Done.
> LayoutTests/editing/pasteboard/script-tests/file-drag-to-editable.js:18
> + function dragFilesOntoEditableArea(files) {
> Please move '{' to the beginning of next line.
>
Done.
> WebCore/platform/android/DragDataAndroid.cpp:71
> + bool DragData::containsURL(FilenameConversionPolicy filenamePolicy) const
> It is better to omit the argument name "filenamePolicy" since otherwise it might break other build for "unused parameter".
>
Done.
> WebCore/platform/android/DragDataAndroid.cpp:76
> + String DragData::asURL(FilenameConversionPolicy filenamePolicy, String*) const
> ditto.
>
Done.
> WebCore/platform/win/ClipboardUtilitiesWin.cpp:366
> + // FIXME: originally, this logic was so dropping files on WebKit would insert the filename.
> The comment "this logic was so dropping files on WebKit" seems to be hard to understand. Could you please rephrase it?
>
Done.
> WebCore/platform/win/ClipboardUtilitiesWin.h:64
> + String getURL(IDataObject*, DragData::FilenameConversionPolicy filenamePolicy, bool& success, String* title = 0);
> The argument name filenamePolicy can be omitted per coding style guideline.
Done.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list