[Webkit-unassigned] [Bug 25528] [Gtk] Text attributes not exposed

Wed Jun 9 10:15:03 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=25528

Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msanchez at igalia.com

--- Comment #13 from Mario Sanchez Prada <msanchez at igalia.com>  2010-06-09 10:15:03 PST ---
(In reply to comment #12)
> Attachment 58253 [details] did not pass style-queue:
> 
> Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
> WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:1255:  webkit_accessible_text_get_run_attributes is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
> WARNING: File exempt from style guide. Skipping: "WebKit/gtk/tests/testatk.c"
> Total errors found: 1 in 4 files

Yes, I already saw that but I don't have a clue of what to do here since it's a common practice in that file to name all the functions for the ATK roles that way.

Any suggestion?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.