[Webkit-unassigned] [Bug 39879] Geolocation activity started after frame has been disconnected can cause crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39879





--- Comment #35 from Steve Block <steveblock at google.com>  2010-06-09 04:06:41 PST ---
> Will the fatal error stay set if a document returns from b/f cache? I'm worried about the following scenario:
> 1. a request is attempted on a document in b/f cache;
> 2. user navigates back, so the document is in frame again;
> 3. Geolocation still doesn't work.
No, the error won't be cleared. You're right that this doesn't handle Geolocation going in and out of the b/f cache. There are already other parts of Geolocation that don't handle this. However, the FrameLoader explicitly prevents pages that use Geolocation from going into the b/f cache.

> Note that even the fact that Geolocation prevents documents from going into b/f cache doesn't necessarily prevent this
> scenario. Step 1 occurs when a document is already in b/f cache.
I wasn't aware of this. My understanding was that script execution is halted once a page is in the b/f cache, so new Geolocation activity isn't possible. Is this correct?

If it is indeed the case that a page using Geolocation can't end up in the b/f cache, then I think this patch is good.

We should certainly look at enabling the b/f cache for Geolocation, and the new architecture you suggest might be a good way to do that, but I think that's a separate issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.