[Webkit-unassigned] [Bug 38664] Web Inspector: add a "table" method to console, to allow output of tabular data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38664





--- Comment #38 from Pavel Feldman <pfeldman at chromium.org>  2010-06-08 13:11:10 PST ---
(From update of attachment 58091)
Quick review without getting into too much details.

WebCore/inspector/front-end/ConsoleView.js:689
 +          this.message = this.formattedMessage.textContent;
indent

WebCore/inspector/front-end/ConsoleView.js:675
 +                  this.formattedMessage = this._format(["%O", args[0]]);
this makes me think we will want %T some day for table :)

WebCore/inspector/front-end/ConsoleView.js:818
 +          function getFormatAsRow(rowElement) {
returning a function from local function is a bit too heavy to my taste.

WebCore/inspector/front-end/ConsoleView.js:808
 +                  for (var i=0; i<array2d.length; i++) {
spaces, need more spaces!

WebCore/manual-tests/inspector/console-table.html:1
 +  <script>
Now that I've spent so much time on testing harness and layout tests, I am saying no to any manual-test attempt. Please look into the LayoutTests/inspector/console* for the hints on how to automate the process. Even dumping div's text content and testing it against golden is better than manual test!

WebCore/page/Console.h:70
 +      ResultMessageType
Is this one actually used?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.