[Webkit-unassigned] [Bug 40278] [EFL] EFLWebKit doesn't support viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40278





--- Comment #2 from Leandro Pereira <leandro at profusion.mobi>  2010-06-08 13:00:03 PST ---
I'm not a reviewer, so consider this as an informal review.

> Index: WebKit/ChangeLog
> +        * efl/EWebLauncher/main.c:
> +        (on_viewport_changed):
> +        (browserCreate):
> +        * efl/WebCoreSupport/ChromeClientEfl.cpp:
> +        (WebCore::ChromeClientEfl::didReceiveViewportArguments):
> +        * efl/ewk/ewk_view.cpp:
> +        (_ewk_view_priv_new):
> +        (ewk_view_zoom_set):
> +        (ewk_view_zoom_weak_set):
> +        (ewk_view_zoom_animated_set):
> +        (ewk_view_load_started):
> +        (ewk_view_set_viewport):
> +        (ewk_view_set_zoom_range):
> +        (ewk_view_set_user_scalable):
> +        * efl/ewk/ewk_view.h:

Try to write small, one-line summaries, explaining the changes.

> Index: WebKit/efl/ewk/ewk_view.cpp
> ===================================================================
> --- WebKit/efl/ewk/ewk_view.cpp	(revision 60742)
> +++ WebKit/efl/ewk/ewk_view.cpp	(working copy)
> @@ -100,6 +100,7 @@ struct _Ewk_View_Private_Data {
>          Eina_Bool resizable_textareas:1;
>          Eina_Bool private_browsing:1;
>          Eina_Bool caret_browsing:1;
> +        Eina_Bool isUserScalable:1;
>      } settings;
>      struct {
>          struct {
> @@ -121,6 +122,10 @@ struct _Ewk_View_Private_Data {
>          Evas_Coord w, h;
>          Eina_Bool use:1;
>      } fixed_layout;
> +    struct {
> +        float minimumScale;
> +        float maximumScale;
> +    } zoom_range;
>  };

Naming isn't consistent with the rest of EWK files. camelCase is used inside WebKit, but EWK prefers unix_hacker_style.


Patch looks fine otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.