[Webkit-unassigned] [Bug 31438] Implement non-scaling-stroke (from SVG Tiny 1.2, also in Opera)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 11:39:08 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=31438





--- Comment #33 from Nikolas Zimmermann <zimmermann at kde.org>  2010-06-08 11:39:04 PST ---
(In reply to comment #32)
> (In reply to comment #31)
> > (From update of attachment 57982 [details] [details])
> > r- because of the style issues :( Looks excellent, other than that.
> 
> The space before the closing brace is missing on the switch statement, thats correct.
> I know the naming convention about leading '_', but won't renaming _vectorEffect cause problems in the perl build code script? Renaming would mean, that all variable names in SVGRenderStyle.h need to be renamed.
Oops, you're right about the last one. So when fixing the first, it's done, I'll set r+, and you can change the space before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list