[Webkit-unassigned] [Bug 39879] Geolocation activity started after frame has been disconnected can cause crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 11:12:40 PDT 2010


--- Comment #30 from Jeremy Orlow <jorlow at chromium.org>  2010-06-08 11:12:38 PST ---
(In reply to comment #29)
> > You think |copyNotifiersToVector(Vector&)| is less clear than |getNotifiersVector(Vector&)|?
> No, I don't :-). I was frantically commenting on a bug with r+ before it got committed, and didn't see what the actual change was, or some of the previous discussion. This new name is fine.
> > I've taken away the r+ per your request, but I think leaving things in this half-working state is worse
> Perhaps. Again, I didn't have the time to think about how these two patches really affect each other.

Sorry about that.  :-)

I've set the review flag again.  Please take a look and r+ if you agree that this should go in even though we're still discussing whether the overall approach (of making things ActiveDOMObjects) is correct.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list