[Webkit-unassigned] [Bug 39879] Geolocation activity started after frame has been disconnected can cause crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 11:03:00 PDT 2010


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #58148|review+                     |
               Flag|                            |

--- Comment #28 from Jeremy Orlow <jorlow at chromium.org>  2010-06-08 11:02:57 PST ---
(From update of attachment 58148)
(In reply to comment #27)
> > I much prefer that name, but maybe AP thinks it should be left?
> Yes, that function should have a "get" prefix.

You think |copyNotifiersToVector(Vector&)| is less clear than |getNotifiersVector(Vector&)|?  I can't say I agree.

> > Marcus, would you mind looking at this before I submit?
> Let me look over this patch in more detail, too. Given the discussion in bug 40162, we may need to spend some more time thinking about this.

I've taken away the r+ per your request, but I think leaving things in this half-working state is worse than letting this go in and then doing subsequent patches based on whatever resolution we come up with in that other bug.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list