[Webkit-unassigned] [Bug 40259] [Qt] EventHandlerQt.cpp has coding-style errors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 10:34:36 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40259


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58077|review?                     |review-
               Flag|                            |




--- Comment #2 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-06-08 10:34:36 PST ---
(From update of attachment 58077)
Please remove "(OOPS!)" from the ChangeLog and perhaps mention why there is no new tests (e.g. "no new functionality" or "style change only").

Also I saw that you have quite a few changes up for review (with similar problems). I think you can combine some of these into a single patch (if all they do is style fixes for QtWebKit).

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list