[Webkit-unassigned] [Bug 40002] Need Geolocation LayoutTest to test case where permission has neither been granted nor denied

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 09:58:28 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40002





--- Comment #7 from Alexey Proskuryakov <ap at webkit.org>  2010-06-08 09:58:28 PST ---
> > This calls out from DRT code, so UIDelegate may be released in the meanwhile.
> > I'd use a local variable for the listener.
> I'm not sure I understand. When would the UI delegate be released while script is still running?

I haven't looked into the details, maybe WebKit can navigate away from the current page during this callback. It's always best not to rely on behavior of delegate calls made into different projects.

> I think the above change is independent of whether the allow/deny callback is completely 
> asynchronous. Is there a particular need for it to be completely asynchronous?

Nothing particular I can think of, just matching "real life" code path better.

> This change is the "minor fix".

OK. It would be nice to say a few words about this in ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list