[Webkit-unassigned] [Bug 40004] [Qt] Support for loading notification icons

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40004


Yael <yael.aharon at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johnnyg at google.com




--- Comment #11 from Yael <yael.aharon at nokia.com>  2010-06-08 09:57:59 PST ---
I can think of 2 ways of implementing an icon loader in cross platform code.
1. Notification object could inherit ThreadableLoaderClient, and handle the download itself, the same way as XMLHttpRequest does.
2. Create a NotificationPresenterProxy class to handle the download. This new class will also implement the interface NotificationPresenter, and will proxy between the NotificationCenter and the platform specific NotificationPresenter.

Advantage of first solution is that it will encapsulate all Notification logic in the Notification object itself.
Advantage of the second solution is that it does not require #ifdef in the code. Ports that don't want to download icons in cross platform code, don't use the NotificationPresenterProxy.

Any opinions on which way to go?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.