[Webkit-unassigned] [Bug 40162] Prevent Geolocation making callbacks to a ScriptExecutionContext that no longer exists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40162





--- Comment #13 from Alexey Proskuryakov <ap at webkit.org>  2010-06-08 09:53:26 PST ---
Sorry for not commenting earlier, it's a busy week.

I strongly dislike having bindings object inherit from ActiveDOMObject. These are not DOM objects regardless of how you slice it!

I think that a better way to fix this would be to factor out "request" objects associated with Geolocation object, and make them reference Geolocation. That way, the design would be closer XMLHttpRequest, and being similar to existing active objects can't do you any harm.

+    ScriptExecutionContext* context = globalObject()->scriptExecutionContext();
+    // We will fail to get the context if the frame has been detached.

That's pretty much the same as relying on DOMWindow::document() returning null. There isn't any deep reason why it's currently returning null.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.