[Webkit-unassigned] [Bug 39721] [chromium] Upstream layout tests expectations for Geolocation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 09:50:01 PDT 2010


--- Comment #19 from Victor Wang <victorw at chromium.org>  2010-06-08 09:50:01 PST ---
(In reply to comment #18)
> (In reply to comment #17)
> > (In reply to comment #16)
> > > (In reply to comment #15)
> > > > Unless there's a good reason to separate win/mac, I think we should go forward with this patch, change the default behavior of the rebaselining tool, and file a bug to unify all the tests which have identical mac/win baselines.
> > > 
> > > I don't think we should put baselines in platform/chromium. We already have a baseline location for each platform and fallback logic works well through platform-linux->platform->win->platform-mac. I don't see much benefit if we add additional layer to this fallback path, but does see there is maintenance cost (either through rebaseline tool or manually update baselines) introduced by this extra location. Like I said, if we have this extra layer and baselines for all three platforms are same, the baseline is added to platform/chromium, then if the baseline for any platform changes, not only you need to add/update the baseline for that location, you may also need to update the other platforms and remove the file from platform/chromium. I don't mean we could not do this in rebaseline tool or manually rebaselining, but think this makes our rebaseline process more complicated and the benefit by adding this extra layer is not much.
> > 
> > By that logic, we should not have linux fall back on the win baselines for the same reason, right?
> Jeremy, maybe I didn't make my comments clearer. I do think we should have linux fallback to win (lots of baselines for linux and win are same). The point I am trying to make here is each baseline location is associated with one platform (mac, win7, vista, winxp, linux etc). The new location platform/chromium is not associate with one platform, it is for hosting files if baselines for all platforms are same. This case has already been handled now by simply adding the baseline to platform-mac. Adding this new location will make the process MORE complicated and seems to me it is not necessary.
> > 
> > Also, if that's the case, we need to move all the baselines out of platform/chromium to avoid further confusion.
> Yes, I agree.

I think it is more logically clear and simple if baseline for each platform are added to it own location and no dupe check if there is no storage concern, but lots of baselines are same so we need the fallback logic to save storage. Adding platform/chromium does not save us any space but does make the process more complicated.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list