[Webkit-unassigned] [Bug 39879] Geolocation activity started after frame has been disconnected can cause crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39879





--- Comment #22 from Jeremy Orlow <jorlow at chromium.org>  2010-06-08 09:16:18 PST ---
(In reply to comment #21)
> > WebCore/page/Geolocation.cpp:508
> >  +      copyToVector(m_oneShots, copy);
> > Do you need to null out the list?
> No, copyValuesToVector() explictly resizes the vector and sets every element

I mean the m_oneShots list.  (Not sure...just asking to make sure you had considered it.)

> > WebCore/page/Geolocation.cpp:510
> >  +      m_watchers.getNotifiersVector(copy);
> > This shouldn't have had get in the name...
> How about 'copyNotifiersToVector()'?

I much prefer that name, but maybe AP thinks it should be left?

> > WebCore/page/Geolocation.cpp:50
> >  +  static const char serviceNoLongerAvailableErrorMessage[] = "Geolocation service no longer available";
> > Are these messages supposed to not have a period at the end?
> I just copied the pattern of the first error message added by Greg in http://trac.webkit.org/changeset/37854/trunk/WebCore/page/Geolocation.cpp I don't have a strong opinion.

Well being consistent here and not changing the existing strings is most important.  Was just asking because I have put a period there on my error messages for IndexedDB...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.