[Webkit-unassigned] [Bug 39721] [chromium] Upstream layout tests expectations for Geolocation.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39721





--- Comment #16 from Victor Wang <victorw at chromium.org>  2010-06-08 09:04:22 PST ---
(In reply to comment #15)
> Unless there's a good reason to separate win/mac, I think we should go forward with this patch, change the default behavior of the rebaselining tool, and file a bug to unify all the tests which have identical mac/win baselines.

I don't think we should put baselines in platform/chromium. We already have a baseline location for each platform and fallback logic works well through platform-linux->platform->win->platform-mac. I don't see much benefit if we add additional layer to this fallback path, but does see there is maintenance cost (either through rebaseline tool or manually update baselines) introduced by this extra location. Like I said, if we have this extra layer and baselines for all three platforms are same, the baseline is added to platform/chromium, then if the baseline for any platform changes, not only you need to add/update the baseline for that location, you may also need to update the other platforms and remove the file from platform/chromium. I don't mean we could not do this in rebaseline tool or manually rebaselining, but think this makes our rebaseline process more complicated and the benefit by adding this extra layer is not much.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.