[Webkit-unassigned] [Bug 39879] Geolocation activity started after frame has been disconnected can cause crash
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 8 08:41:05 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=39879
--- Comment #19 from Jeremy Orlow <jorlow at chromium.org> 2010-06-08 08:41:02 PST ---
(In reply to comment #18)
> > + m_watchers.getNotifiersVector(copy);
> > This shouldn't have had get in the name...
>
> Why not?
http://webkit.org/coding/coding-style.html
Precede setters with the word "set". Use bare words for getters. Setter and getter names should match the names of the variables being set/gotten.
Right:
void setCount(size_t); // sets m_count
size_t count(); // returns m_count
Wrong:
void setCount(size_t); // sets m_theCount
size_t getCount();
Now that I think about it, this isn't strictly a getter...I wonder if a better verb could be used though.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list