[Webkit-unassigned] [Bug 40250] Adds IndexedDB's KeyRange.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40250





--- Comment #4 from Marcus Bulach <bulach at chromium.org>  2010-06-08 05:51:11 PST ---
(In reply to comment #2)
> (From update of attachment 58065 [details])
> Looking pretty good....
thanks Jeremy! all comments addressed, another look please?

> 
> WebCore/storage/IndexedDatabaseRequest.idl:32
>  +          IDBKeyRange makeSingleKeyRange(in SerializedScriptValue value);
> Use [Optional] after the "in" for all the optional args and get rid of the comment documenting it.  Put them all on the same line.
done.

> 
> WebCore/storage/IndexedDatabaseRequest.h:60
>  +      PassRefPtr<IDBKeyRange> makeBoundKeyRange(PassRefPtr<SerializedScriptValue> left, PassRefPtr<SerializedScriptValue> right, bool openLeft, bool openRight);
> For the optional parameters, put the default here (i.e. |bool open = false|).
done.

> 
> WebCore/storage/IDBKeyRange.idl:31
>  +          const unsigned short SINGLE = 0;
> Add "// Keep in sync with what's in the .h file."
done.

> 
> WebCore/storage/IDBKeyRange.h:57
>  +      PassRefPtr<IDBAny> left() { return m_left; }
> const for all 3
done.

> 
> WebCore/storage/IndexedDatabaseRequest.cpp:65
>  +      SerializedScriptValue* rawValue = value.releaseRef();
> Now is a good time to read http://webkit.org/coding/RefPtr.html again.
> 
> PassRefPtr<IDBKeyRange> IndexedDatabaseRequest::makeSingleKeyRange(PassRefPtr<SerializedScriptValue> prpValue) {
> RefPtr<SerializedScriptValue> value = prpValue;

thanks for the refresher! done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.