[Webkit-unassigned] [Bug 40201] Unify fileSystemRepresentation and filenameFromString

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40201





--- Comment #7 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2010-06-07 18:43:49 PST ---
(In reply to comment #6)
> (From update of attachment 57991 [details])
> Looks good to me as far as most ports are concerned, but I don't understand what Gtk/Efl were doing here. Maybe someone working on Gtk should take a look, too.
> 
> -    char* filename = g_uri_unescape_string(string.utf8().data(), 0);
> +    char* filename = g_uri_unescape_string(path.utf8().data(), 0);

We can see the reason from the following ChangeLog.

2008-10-15  Marco Barisione  <marco.barisione at collabora.co.uk>

        Reviewed by Holger Freyther.

        http://bugs.webkit.org/show_bug.cgi?id=20664
        [GTK] File names are not always encodable in UTF-8

        On Linux file names are just raw data and cannot always be directly
        encoded in UTF-8 or in any other encodings, so we escape them before
        storing the file name in a String and unescape them before passing
        them to native functions handling files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.