[Webkit-unassigned] [Bug 40250] Adds IndexedDB's KeyRange.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 12:40:12 PDT 2010


--- Comment #2 from Jeremy Orlow <jorlow at chromium.org>  2010-06-07 12:40:12 PST ---
(From update of attachment 58065)
Looking pretty good....

 +          IDBKeyRange makeSingleKeyRange(in SerializedScriptValue value);
Use [Optional] after the "in" for all the optional args and get rid of the comment documenting it.  Put them all on the same line.

 +      PassRefPtr<IDBKeyRange> makeBoundKeyRange(PassRefPtr<SerializedScriptValue> left, PassRefPtr<SerializedScriptValue> right, bool openLeft, bool openRight);
For the optional parameters, put the default here (i.e. |bool open = false|).

 +          const unsigned short SINGLE = 0;
Add "// Keep in sync with what's in the .h file."

 +      PassRefPtr<IDBAny> left() { return m_left; }
const for all 3

 +      SerializedScriptValue* rawValue = value.releaseRef();
Now is a good time to read http://webkit.org/coding/RefPtr.html again.

PassRefPtr<IDBKeyRange> IndexedDatabaseRequest::makeSingleKeyRange(PassRefPtr<SerializedScriptValue> prpValue) {
RefPtr<SerializedScriptValue> value = prpValue;

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list