[Webkit-unassigned] [Bug 40250] Adds IndexedDB's KeyRange.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40250





--- Comment #2 from Jeremy Orlow <jorlow at chromium.org>  2010-06-07 12:40:12 PST ---
(From update of attachment 58065)
Looking pretty good....

WebCore/storage/IndexedDatabaseRequest.idl:32
 +          IDBKeyRange makeSingleKeyRange(in SerializedScriptValue value);
Use [Optional] after the "in" for all the optional args and get rid of the comment documenting it.  Put them all on the same line.

WebCore/storage/IndexedDatabaseRequest.h:60
 +      PassRefPtr<IDBKeyRange> makeBoundKeyRange(PassRefPtr<SerializedScriptValue> left, PassRefPtr<SerializedScriptValue> right, bool openLeft, bool openRight);
For the optional parameters, put the default here (i.e. |bool open = false|).

WebCore/storage/IDBKeyRange.idl:31
 +          const unsigned short SINGLE = 0;
Add "// Keep in sync with what's in the .h file."

WebCore/storage/IDBKeyRange.h:57
 +      PassRefPtr<IDBAny> left() { return m_left; }
const for all 3

WebCore/storage/IndexedDatabaseRequest.cpp:65
 +      SerializedScriptValue* rawValue = value.releaseRef();
Now is a good time to read http://webkit.org/coding/RefPtr.html again.

PassRefPtr<IDBKeyRange> IndexedDatabaseRequest::makeSingleKeyRange(PassRefPtr<SerializedScriptValue> prpValue) {
RefPtr<SerializedScriptValue> value = prpValue;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.