[Webkit-unassigned] [Bug 30116] WebCore::InsertLineBreakCommand::shouldUseBreakElement ReadAV at NULL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30116


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |adele at apple.com,
                   |                            |jparent at google.com,
                   |                            |ojan at chromium.org




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org>  2010-06-07 11:52:56 PST ---
+jparent & +ojan since they're knowledgeable about how rich text edit should behave.
+adele since she's knowledgeable about forms.

(In reply to comment #7)
> Ryosuke's analysis is correct.  The textarea is hidden in keydown, but we try to use the visible position when inserting the line break.  There is no visible position since the textarea is hidden, so we dereference a null pointer.

This seems to be a yet another problem caused by VisiblePosition.  Julie & Ojan, does it make sense for us to ignore text input if the textarea is hidden?

> This patch just does a null pointer check on the visible position.

I'm not sure if InsertLikeBreakCommand is the right place to deal with this problem.  It seems like we should be stop propagating all text input commands or similar commands whenever VisiblePosition is null.

> - Firefox is able to insert the line break in this test case.

That's what I thought.  Firefox doesn't canonicalize positions so this shouldn't be a problem for them.  On the other hand, Internet Explorer won't add the line break in this test so new behavior matches MSIE.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.