[Webkit-unassigned] [Bug 38050] Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38050





--- Comment #6 from Ben Murdoch <benm at google.com>  2010-06-07 10:33:16 PST ---
Spent a bit of time this afternoon and have found out the following:

When you change the visibility of an element, we treat this as only needing to do a repaint (see http://trac.webkit.org/browser/trunk/WebCore/rendering/style/RenderStyle.cpp#L509). When going from visible to hidden and vice versa, this is enough.

However in the initial layout we seem to skip elements that have visibility collapse (see http://trac.webkit.org/browser/trunk/WebCore/rendering/RenderFlexibleBox.cpp#L93). So (I think) when we come to do the repaint triggered by the change from visible to collapse we still skip them as we don't rerun a layout.

This seems to be confirmed by triggering a layout after swapping from collapse to visible - the bug is fixed. I added

    if (inherited_flags._visibility == COLLAPSE && other->inherited_flags._visibility == VISIBLE)
        return StyleDifferenceLayout;

to RenderStyle::diff. What do you think?

Please forgive me if I'm talking nonsense. I'm not very familiar with the layout code (although I'd like to learn it) but would like to see this bug fixed.

Thanks, Ben

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.