[Webkit-unassigned] [Bug 40230] run-bindings-tests results broken by Changeset 60776
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 7 10:21:50 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=40230
--- Comment #5 from Andrei Popescu <andreip at google.com> 2010-06-07 10:21:50 PST ---
(In reply to comment #2)
> (From update of attachment 58017 [details])
> I'm confused. There is a functional change here. Why are we changing CodeGeneratorJS.pm if this is just supposed to update test reuslts?
That code in CodeGeneratorJS.pm was added by me in
http://trac.webkit.org/changeset/60776/trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm
Unfortunately, when I tried to submit the change, I noticed a conflict due to this change that was submitted just seconds before my attempt:
http://trac.webkit.org/changeset/60775
I rebased and solved the conflict but got confused and solved the conflict the wrong way. The problem was that, after I got the r+ for my patch but before I submitted, the CodeGeneratorJS.pm was modified to make native functions return EncodedJSValue instead of JSValues.
http://trac.webkit.org/changeset/60631/trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm
So when I solved my conflict, instead of what I did, I should have updated my change to the Code Generator so that it would also return a EncodedJSValue and then then re-invoke "run-bindings-tests". This patch does just that.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list