[Webkit-unassigned] [Bug 39058] old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 09:49:18 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39058





--- Comment #12 from Eric Seidel <eric at webkit.org>  2010-06-07 09:49:17 PST ---
Yes, this is the wrong way to launch scripts:

 1441     `./WebKitTools/Scripts/ensure-valid-python --check-only`;

The perl code is lame about how it handles paths.  The python code always uses absolute paths.  The other callsites make similar relative-path calls and get away with it because they're after the chdirWebKit() call in old-run-webkit-tests.

I think you should instead make your path absolute using sourceDir() from webkitdirs.  You could also use relativeScriptsDir().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list