[Webkit-unassigned] [Bug 25645] SVG - numeric overflow for very large elements

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 08:32:41 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=25645





--- Comment #35 from W. James MacLean <wjmaclean at chromium.org>  2010-06-07 08:32:39 PST ---
(In reply to comment #34)
> (From update of attachment 57913 [details])
> 
> WebCore/platform/graphics/FloatRect.cpp:124
>  +      float lf = floorf(rect.x());
> Please use descriptive variable names like "left" "right" "top" "bottom" here.

I will improve these names ... I just re-used the existing names.

> WebCore/platform/graphics/FloatRect.cpp:126
>  +      float wf = ceilf(rect.right()) - lf ;
> Why do we need to use right - left here to figure out the width? Why is using width() not sufficient?
> 

I think we need 'right - left' since we want an enclosing rect, and 

ceil(right) - floor(left) 

is not going to equal 

round/ceil/floor (right - left)

in general (where width = right - left).

> Waiting your new patch :-)
> I guess you tested running all webkit tests - enclosingIntRect() is used in lots of places - and I am afraid of side-effects in tests. Please rule that out.

I believe I am running the full set of tests, but will verify.

Cheers,

James

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list