[Webkit-unassigned] [Bug 36282] CSS3 "Property is declared twice in rule" test fails

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 6 23:43:16 PDT 2010


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
                 CC|                            |rwlbuis at gmail.com

--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2010-06-06 23:43:16 PST ---
(In reply to comment #1)
> Created an attachment (id=57994)
 --> (https://bugs.webkit.org/attachment.cgi?id=57994) [details]
> Patch

This is just a first stab and at least has one style problem. I uploaded it anyway to get some early feedback. If I understand it correctly, earlier !important properties should not be removed, hence
the check. However additionaly there seems a problem with how to treat padding. One of the failing
cases was padding: 5em; padding: -1em. Before my patch -1em was discarded so 5em "won" hence
the test passing. With my patch 5em is removed and later on -1em is discarded. When I inspect this
rule in Opera, it doesn't even mention the -1em, so I am guessing there it is stripped out in the css parsing phase. Since I would not like special casing CSSPaddingProperty (and there may be even more
exceptions) I am not sure how to fix that. Should we try to discard negative padding earlier? Will that cause problems with other testcases?


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list