[Webkit-unassigned] [Bug 39083] Refactor FormData and Blob for better support of Blobs synthesized by BlobBuilder

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39083


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57922|review?                     |review-
               Flag|                            |




--- Comment #58 from Jian Li <jianli at chromium.org>  2010-06-04 16:49:47 PST ---
(From update of attachment 57922)
Looks generally good. Just several more comments.

WebCore/ChangeLog:9
 +            FormDataList and makes Blob as a collection of BlobItems.
The 2nd part after "and" seems to be redundant.

WebCore/ChangeLog:49
 +          (WebCore::FormDataList::appendString):
Please also mention here that the line ending fix logic has been moved to StringBlobItem::convertToCString.

WebCore/platform/network/FormData.cpp:217
 +          const RefPtr<BlobItem> value = items[i + 1];
Might be better to use "const BlobItem*" in order to be consistent with previous line.

WebCore/platform/network/FormData.h:23
 +  #include "BlobItem.h"
It seems that we do not need to include BlobItem.h. Instead we can add forward reference to BlobItem and BlobItemList.

WebKit/chromium/src/WebSearchableFormData.cpp:201
 +            if (!item)
Is there any case that the current item is not StringBlobItem? I think we rather throw ASSERT here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.