[Webkit-unassigned] [Bug 39691] [Qt] GraphicsLayer: support tiling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39691





--- Comment #8 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-04 12:54:42 PST ---
(From update of attachment 57827)
Generally looks good to me, but it would be nice if Antti could have a look.

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:50
 +  #define GRAPHICS_LAYER_TILING_THRESHOLD 2000
We shouldnt use defines, you can use a static const. and also please do not use capitalized naming, gGraphicsLayerTilingThreshold would be fine.

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:119
 +          , public virtual TiledBackingStoreClient
Should have indentation of 4

WebCore/platform/graphics/qt/GraphicsLayerQt.cpp:841
 +      return mapFromScene(view->mapToScene(view->viewport()->visibleRegion().boundingRect()).boundingRect()).boundingRect().toAlignedRect();
Wow, lots of bounding here :-) Antti, is there no better way of doing this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.