[Webkit-unassigned] [Bug 40179] New: Re-enable JIT_OPTIMIZE_NATIVE_CALL on MIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40179

           Summary: Re-enable JIT_OPTIMIZE_NATIVE_CALL on MIPS
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: fu at mips.com
                CC: ggaren at apple.com


Hi All,

  I will submit a patch to re-enable JIT_OPTIMIZE_NATIVE_CALL on MIPS.
One issue that I have is in JITOpcodes.cpp.
Ex:
JIT::Label JIT::privateCompileCTINativeCall(JSGlobalData* globalData, bool isConstruct)
{
... 
    poke(callFrameRegister, 1 + OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof (void*)); <-------
    poke(ImmPtr(FunctionPtr(ctiVMThrowTrampoline).value()));

    ret();

    return nativeCallThunk;
}

Why do we put callFrameRegister to the stack location of 1 + OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof (void*)?
Previously, we put it to the location of OBJECT_OFFSETOF(struct JITStackFrame, callFrame) / sizeof (void*).

Thanks!

Regards,
Chao-ying

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.