[Webkit-unassigned] [Bug 40054] [indexedDB] It is impossible to create object stores

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40054


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57882|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #21 from Jeremy Orlow <jorlow at chromium.org>  2010-06-04 08:48:22 PST ---
(From update of attachment 57882)
WebCore/ChangeLog:12
 +          * Android.mk:
regenerate list

WebCore/storage/IndexedDatabaseRequest.cpp:57
 +          // FIXME: make this work with workers.
ASSERT_NOT_REACHED()
WebCore/storage/IndexedDatabaseRequest.cpp:63
 +          return 0;
Didn't we agree to return an IDBRequest that'll just never fire?

WebCore/storage/IndexedDatabaseRequest.cpp:61
 +      Document* doc = static_cast<Document*>(context);
don't abbreviate 

WebKit/chromium/public/WebIDBDatabase.h:64
 +          WEBKIT_ASSERT_NOT_REACHED();
Might be slightly better to assign the WebIDBCallbacks to an OwnPtr so you don't leak and to make it obvious to whomever implements this that it's an owning relationship...but this code is going away soon anyway so I don't care much.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.